Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

JS error on surah click #349

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Conversation

mahboob-awan
Copy link
Contributor

Getting error locally, on Surah's label click action.

@mmahalwy mmahalwy merged commit 0f214b0 into quran:develop Jun 25, 2016
@mahboob-awan mahboob-awan deleted the surah-javascript-error branch June 25, 2016 18:23
mmahalwy added a commit that referenced this pull request Jul 10, 2016
* HOTFIX reading mode markers (#303)

* Default api and files (#306)

* Reducing bundle size (#310)

* Reducing bundle size

* rearranged files

* more rearrange and deleted unneeded files

* add default segments key (#313)

* transitioning to al-quran al-kareem (#314)

transitioning to Al-Quran al-Kareem

* Fix lint issues

* Update Readme.md

* Add devDependency Status

* Update Readme for new developers

* Code splitting assets (#321)

* Code splitting

* Split the html files into their own and ajax requested

* Pass tests

* Wrong files

* Add segments

* Add segments

* Autocomplete pointing to v2 suggest

* HOTFIX pretty-error dep (#323)

* HOTFIX Search to the right route (#324)

* No segments for non-segmented reciters (#325)

* Adding sentry (#327)

* CDN images for surahinfo (#328)

* Reduce data dehydration (#329)

* Search Action on homepage (#330)

* Descriptions for surahs (#331)

* Fixed head tags (#332)

* Head tags improved and more organized

* Fixed the head problem

* audioplayer bug fixes, or more bugs (#335)

* audioplayer bug fixes, or more bugs

* removes some unneeded state things in audioplayer redux, also fixes a bug where event listeners would get bound without properly unbinding multiple times, which caused the player to skip ayahs after using next <-> prev more then once on the same ayah

* temporarily disables word focusing capacity

* Add sourcemaps to prod

* Remove zero padding in urls

* (WIP) Issue #248 (#336)

Fixes #248 Out of range bug

* correct waffle url. (#338)

* JS error on surah click (#349)

* Add Heroku generated app.json

* Ramadan Todo list (#343)

* Change

* Eslint added (#345)

* Eslint added

* eslint in travis

* ayah require

* Fixed

* fixed bug that was preventing ayah transition on audioplayer

* fix autocomplete thing

* Extract connect from the surah container (#347)

* Fout fonts (#346)

* Fout fonts

* wip

* wip2

* do not update

* pass tests

* Sourcemap for sentry (#352)

* contribution guideline (#355)

* Heroku pipeline trials (#354)

* push

* push

* push

* push

* push

* Heroku push (#356)

* Heroku push

* public urls

* Add zendesk widget (#358)

* Fix font artifacts

This fixes #365 by merging the 3 fonts from quran/quran.com-images#7,
quran/quran.com-images#8, and quran/quran.com-images#9.

* Update font for page 237 to fix spacing in 12:17

This fixes the spacing issue in 12:17 by updating the font. Fixes #369.

* Feature/341 social share (#367)

* Add zendesk widget (#358)

*  The first commit's message is:

* Simplify audioplayer (#360)

* Audioplayer refactor

* more reshuffling

* move logic outside of tracker

* fixes #359

* eslint

* refactor and works

* Added segments

* Fix navigating from home to surah

* reciter change

* on word click working!

* segments encryption and lazy decryption

* encryption lib

* linter is happy

* unit tests

* env

* Fix sentry bug (#373)

* Fix sentry bug

* no build

* #372 colon separated surah/ayah (#374)

* #372 colon separated surah/ayah

* #372 colon separated surah/ayah

* #372 colon separated surah/ayah

* Re-output fonts with Apple option enabled

This probably doesn't matter for web, but it may matter for apps in the
future, plus wanted to keep in sync with the versions of the fonts used
by quran/quran.com-images.

* Tooltip options for translation and transliteration (#376)

* Reading mode single line (#377)

* - ayah's have link (discuss, maybe not needed) (#379)

- Fix audio player playing text
- Remove unneeded padding on mobile
- Hide Share on mobile devices (native share is built into the browsers)

* Added Mixpanel (#384)

* Remove footer links (#385)

* Remove footer links

* eslint

* Fix json-ld (#386)
@mahboob-awan mahboob-awan restored the surah-javascript-error branch July 16, 2016 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants